This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Rename LITTLE_ENDIAN and BIG_ENDIAN defines #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System-wide endian.h already defines both LITTLE_ENDIAN and BIG_ENDIAN as part of BSD compatibility. This commit adds BMI160_ prefix to them in order to fix this name collision. At least link below speak about this issue: https://bugs.launchpad.net/gcc-arm-embedded/+bug/1609078
Thannoy
changed the title
Rebase endianess macro renaming to current master on which ELD changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System-wide endian.h already defines both LITTLE_ENDIAN and BIG_ENDIAN as part of BSD compatibility.
Before this fix, since little endianess is always tested first, it is likely to be always selected even on big endian machines.
This commit adds "BMI160_" prefix to them in order to fix this name collision.
At least link below speak about this issue:
https://bugs.launchpad.net/gcc-arm-embedded/+bug/1609078